intel_dvo.c 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552
  1. /*
  2. * Copyright 2006 Dave Airlie <airlied@linux.ie>
  3. * Copyright © 2006-2007 Intel Corporation
  4. *
  5. * Permission is hereby granted, free of charge, to any person obtaining a
  6. * copy of this software and associated documentation files (the "Software"),
  7. * to deal in the Software without restriction, including without limitation
  8. * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  9. * and/or sell copies of the Software, and to permit persons to whom the
  10. * Software is furnished to do so, subject to the following conditions:
  11. *
  12. * The above copyright notice and this permission notice (including the next
  13. * paragraph) shall be included in all copies or substantial portions of the
  14. * Software.
  15. *
  16. * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
  19. * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21. * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22. * DEALINGS IN THE SOFTWARE.
  23. *
  24. * Authors:
  25. * Eric Anholt <eric@anholt.net>
  26. */
  27. #include <linux/i2c.h>
  28. #include <linux/slab.h>
  29. #include <drm/drmP.h>
  30. #include <drm/drm_atomic_helper.h>
  31. #include <drm/drm_crtc.h>
  32. #include "intel_drv.h"
  33. #include <drm/i915_drm.h>
  34. #include "i915_drv.h"
  35. #include "dvo.h"
  36. #define SIL164_ADDR 0x38
  37. #define CH7xxx_ADDR 0x76
  38. #define TFP410_ADDR 0x38
  39. #define NS2501_ADDR 0x38
  40. static const struct intel_dvo_device intel_dvo_devices[] = {
  41. {
  42. .type = INTEL_DVO_CHIP_TMDS,
  43. .name = "sil164",
  44. .dvo_reg = DVOC,
  45. .slave_addr = SIL164_ADDR,
  46. .dev_ops = &sil164_ops,
  47. },
  48. {
  49. .type = INTEL_DVO_CHIP_TMDS,
  50. .name = "ch7xxx",
  51. .dvo_reg = DVOC,
  52. .slave_addr = CH7xxx_ADDR,
  53. .dev_ops = &ch7xxx_ops,
  54. },
  55. {
  56. .type = INTEL_DVO_CHIP_TMDS,
  57. .name = "ch7xxx",
  58. .dvo_reg = DVOC,
  59. .slave_addr = 0x75, /* For some ch7010 */
  60. .dev_ops = &ch7xxx_ops,
  61. },
  62. {
  63. .type = INTEL_DVO_CHIP_LVDS,
  64. .name = "ivch",
  65. .dvo_reg = DVOA,
  66. .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
  67. .dev_ops = &ivch_ops,
  68. },
  69. {
  70. .type = INTEL_DVO_CHIP_TMDS,
  71. .name = "tfp410",
  72. .dvo_reg = DVOC,
  73. .slave_addr = TFP410_ADDR,
  74. .dev_ops = &tfp410_ops,
  75. },
  76. {
  77. .type = INTEL_DVO_CHIP_LVDS,
  78. .name = "ch7017",
  79. .dvo_reg = DVOC,
  80. .slave_addr = 0x75,
  81. .gpio = GMBUS_PIN_DPB,
  82. .dev_ops = &ch7017_ops,
  83. },
  84. {
  85. .type = INTEL_DVO_CHIP_TMDS,
  86. .name = "ns2501",
  87. .dvo_reg = DVOB,
  88. .slave_addr = NS2501_ADDR,
  89. .dev_ops = &ns2501_ops,
  90. }
  91. };
  92. struct intel_dvo {
  93. struct intel_encoder base;
  94. struct intel_dvo_device dev;
  95. struct intel_connector *attached_connector;
  96. bool panel_wants_dither;
  97. };
  98. static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
  99. {
  100. return container_of(encoder, struct intel_dvo, base);
  101. }
  102. static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
  103. {
  104. return enc_to_dvo(intel_attached_encoder(connector));
  105. }
  106. static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
  107. {
  108. struct drm_device *dev = connector->base.dev;
  109. struct drm_i915_private *dev_priv = dev->dev_private;
  110. struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
  111. u32 tmp;
  112. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  113. if (!(tmp & DVO_ENABLE))
  114. return false;
  115. return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
  116. }
  117. static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
  118. enum pipe *pipe)
  119. {
  120. struct drm_device *dev = encoder->base.dev;
  121. struct drm_i915_private *dev_priv = dev->dev_private;
  122. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  123. u32 tmp;
  124. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  125. if (!(tmp & DVO_ENABLE))
  126. return false;
  127. *pipe = PORT_TO_PIPE(tmp);
  128. return true;
  129. }
  130. static void intel_dvo_get_config(struct intel_encoder *encoder,
  131. struct intel_crtc_state *pipe_config)
  132. {
  133. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  134. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  135. u32 tmp, flags = 0;
  136. tmp = I915_READ(intel_dvo->dev.dvo_reg);
  137. if (tmp & DVO_HSYNC_ACTIVE_HIGH)
  138. flags |= DRM_MODE_FLAG_PHSYNC;
  139. else
  140. flags |= DRM_MODE_FLAG_NHSYNC;
  141. if (tmp & DVO_VSYNC_ACTIVE_HIGH)
  142. flags |= DRM_MODE_FLAG_PVSYNC;
  143. else
  144. flags |= DRM_MODE_FLAG_NVSYNC;
  145. pipe_config->base.adjusted_mode.flags |= flags;
  146. pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
  147. }
  148. static void intel_disable_dvo(struct intel_encoder *encoder)
  149. {
  150. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  151. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  152. u32 dvo_reg = intel_dvo->dev.dvo_reg;
  153. u32 temp = I915_READ(dvo_reg);
  154. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
  155. I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
  156. I915_READ(dvo_reg);
  157. }
  158. static void intel_enable_dvo(struct intel_encoder *encoder)
  159. {
  160. struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
  161. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  162. struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
  163. u32 dvo_reg = intel_dvo->dev.dvo_reg;
  164. u32 temp = I915_READ(dvo_reg);
  165. intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
  166. &crtc->config->base.mode,
  167. &crtc->config->base.adjusted_mode);
  168. I915_WRITE(dvo_reg, temp | DVO_ENABLE);
  169. I915_READ(dvo_reg);
  170. intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
  171. }
  172. static enum drm_mode_status
  173. intel_dvo_mode_valid(struct drm_connector *connector,
  174. struct drm_display_mode *mode)
  175. {
  176. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  177. const struct drm_display_mode *fixed_mode =
  178. to_intel_connector(connector)->panel.fixed_mode;
  179. int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
  180. int target_clock = mode->clock;
  181. if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
  182. return MODE_NO_DBLESCAN;
  183. /* XXX: Validate clock range */
  184. if (fixed_mode) {
  185. if (mode->hdisplay > fixed_mode->hdisplay)
  186. return MODE_PANEL;
  187. if (mode->vdisplay > fixed_mode->vdisplay)
  188. return MODE_PANEL;
  189. target_clock = fixed_mode->clock;
  190. }
  191. if (target_clock > max_dotclk)
  192. return MODE_CLOCK_HIGH;
  193. return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
  194. }
  195. static bool intel_dvo_compute_config(struct intel_encoder *encoder,
  196. struct intel_crtc_state *pipe_config)
  197. {
  198. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  199. const struct drm_display_mode *fixed_mode =
  200. intel_dvo->attached_connector->panel.fixed_mode;
  201. struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
  202. /* If we have timings from the BIOS for the panel, put them in
  203. * to the adjusted mode. The CRTC will be set up for this mode,
  204. * with the panel scaling set up to source from the H/VDisplay
  205. * of the original mode.
  206. */
  207. if (fixed_mode)
  208. intel_fixed_panel_mode(fixed_mode, adjusted_mode);
  209. return true;
  210. }
  211. static void intel_dvo_pre_enable(struct intel_encoder *encoder)
  212. {
  213. struct drm_device *dev = encoder->base.dev;
  214. struct drm_i915_private *dev_priv = dev->dev_private;
  215. struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
  216. const struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
  217. struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
  218. int pipe = crtc->pipe;
  219. u32 dvo_val;
  220. u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
  221. switch (dvo_reg) {
  222. case DVOA:
  223. default:
  224. dvo_srcdim_reg = DVOA_SRCDIM;
  225. break;
  226. case DVOB:
  227. dvo_srcdim_reg = DVOB_SRCDIM;
  228. break;
  229. case DVOC:
  230. dvo_srcdim_reg = DVOC_SRCDIM;
  231. break;
  232. }
  233. /* Save the data order, since I don't know what it should be set to. */
  234. dvo_val = I915_READ(dvo_reg) &
  235. (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
  236. dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
  237. DVO_BLANK_ACTIVE_HIGH;
  238. if (pipe == 1)
  239. dvo_val |= DVO_PIPE_B_SELECT;
  240. dvo_val |= DVO_PIPE_STALL;
  241. if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
  242. dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
  243. if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
  244. dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
  245. /*I915_WRITE(DVOB_SRCDIM,
  246. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  247. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
  248. I915_WRITE(dvo_srcdim_reg,
  249. (adjusted_mode->crtc_hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
  250. (adjusted_mode->crtc_vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
  251. /*I915_WRITE(DVOB, dvo_val);*/
  252. I915_WRITE(dvo_reg, dvo_val);
  253. }
  254. /**
  255. * Detect the output connection on our DVO device.
  256. *
  257. * Unimplemented.
  258. */
  259. static enum drm_connector_status
  260. intel_dvo_detect(struct drm_connector *connector, bool force)
  261. {
  262. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  263. DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
  264. connector->base.id, connector->name);
  265. return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
  266. }
  267. static int intel_dvo_get_modes(struct drm_connector *connector)
  268. {
  269. struct drm_i915_private *dev_priv = connector->dev->dev_private;
  270. const struct drm_display_mode *fixed_mode =
  271. to_intel_connector(connector)->panel.fixed_mode;
  272. /* We should probably have an i2c driver get_modes function for those
  273. * devices which will have a fixed set of modes determined by the chip
  274. * (TV-out, for example), but for now with just TMDS and LVDS,
  275. * that's not the case.
  276. */
  277. intel_ddc_get_modes(connector,
  278. intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
  279. if (!list_empty(&connector->probed_modes))
  280. return 1;
  281. if (fixed_mode) {
  282. struct drm_display_mode *mode;
  283. mode = drm_mode_duplicate(connector->dev, fixed_mode);
  284. if (mode) {
  285. drm_mode_probed_add(connector, mode);
  286. return 1;
  287. }
  288. }
  289. return 0;
  290. }
  291. static void intel_dvo_destroy(struct drm_connector *connector)
  292. {
  293. drm_connector_cleanup(connector);
  294. intel_panel_fini(&to_intel_connector(connector)->panel);
  295. kfree(connector);
  296. }
  297. static const struct drm_connector_funcs intel_dvo_connector_funcs = {
  298. .dpms = drm_atomic_helper_connector_dpms,
  299. .detect = intel_dvo_detect,
  300. .destroy = intel_dvo_destroy,
  301. .fill_modes = drm_helper_probe_single_connector_modes,
  302. .atomic_get_property = intel_connector_atomic_get_property,
  303. .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
  304. .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
  305. };
  306. static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
  307. .mode_valid = intel_dvo_mode_valid,
  308. .get_modes = intel_dvo_get_modes,
  309. .best_encoder = intel_best_encoder,
  310. };
  311. static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
  312. {
  313. struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
  314. if (intel_dvo->dev.dev_ops->destroy)
  315. intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
  316. intel_encoder_destroy(encoder);
  317. }
  318. static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
  319. .destroy = intel_dvo_enc_destroy,
  320. };
  321. /**
  322. * Attempts to get a fixed panel timing for LVDS (currently only the i830).
  323. *
  324. * Other chips with DVO LVDS will need to extend this to deal with the LVDS
  325. * chip being on DVOB/C and having multiple pipes.
  326. */
  327. static struct drm_display_mode *
  328. intel_dvo_get_current_mode(struct drm_connector *connector)
  329. {
  330. struct drm_device *dev = connector->dev;
  331. struct drm_i915_private *dev_priv = dev->dev_private;
  332. struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
  333. uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
  334. struct drm_display_mode *mode = NULL;
  335. /* If the DVO port is active, that'll be the LVDS, so we can pull out
  336. * its timings to get how the BIOS set up the panel.
  337. */
  338. if (dvo_val & DVO_ENABLE) {
  339. struct drm_crtc *crtc;
  340. int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;
  341. crtc = intel_get_crtc_for_pipe(dev, pipe);
  342. if (crtc) {
  343. mode = intel_crtc_mode_get(dev, crtc);
  344. if (mode) {
  345. mode->type |= DRM_MODE_TYPE_PREFERRED;
  346. if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
  347. mode->flags |= DRM_MODE_FLAG_PHSYNC;
  348. if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
  349. mode->flags |= DRM_MODE_FLAG_PVSYNC;
  350. }
  351. }
  352. }
  353. return mode;
  354. }
  355. void intel_dvo_init(struct drm_device *dev)
  356. {
  357. struct drm_i915_private *dev_priv = dev->dev_private;
  358. struct intel_encoder *intel_encoder;
  359. struct intel_dvo *intel_dvo;
  360. struct intel_connector *intel_connector;
  361. int i;
  362. int encoder_type = DRM_MODE_ENCODER_NONE;
  363. intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
  364. if (!intel_dvo)
  365. return;
  366. intel_connector = intel_connector_alloc();
  367. if (!intel_connector) {
  368. kfree(intel_dvo);
  369. return;
  370. }
  371. intel_dvo->attached_connector = intel_connector;
  372. intel_encoder = &intel_dvo->base;
  373. drm_encoder_init(dev, &intel_encoder->base,
  374. &intel_dvo_enc_funcs, encoder_type);
  375. intel_encoder->disable = intel_disable_dvo;
  376. intel_encoder->enable = intel_enable_dvo;
  377. intel_encoder->get_hw_state = intel_dvo_get_hw_state;
  378. intel_encoder->get_config = intel_dvo_get_config;
  379. intel_encoder->compute_config = intel_dvo_compute_config;
  380. intel_encoder->pre_enable = intel_dvo_pre_enable;
  381. intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
  382. intel_connector->unregister = intel_connector_unregister;
  383. /* Now, try to find a controller */
  384. for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
  385. struct drm_connector *connector = &intel_connector->base;
  386. const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
  387. struct i2c_adapter *i2c;
  388. int gpio;
  389. bool dvoinit;
  390. enum pipe pipe;
  391. uint32_t dpll[I915_MAX_PIPES];
  392. /* Allow the I2C driver info to specify the GPIO to be used in
  393. * special cases, but otherwise default to what's defined
  394. * in the spec.
  395. */
  396. if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
  397. gpio = dvo->gpio;
  398. else if (dvo->type == INTEL_DVO_CHIP_LVDS)
  399. gpio = GMBUS_PIN_SSC;
  400. else
  401. gpio = GMBUS_PIN_DPB;
  402. /* Set up the I2C bus necessary for the chip we're probing.
  403. * It appears that everything is on GPIOE except for panels
  404. * on i830 laptops, which are on GPIOB (DVOA).
  405. */
  406. i2c = intel_gmbus_get_adapter(dev_priv, gpio);
  407. intel_dvo->dev = *dvo;
  408. /* GMBUS NAK handling seems to be unstable, hence let the
  409. * transmitter detection run in bit banging mode for now.
  410. */
  411. intel_gmbus_force_bit(i2c, true);
  412. /* ns2501 requires the DVO 2x clock before it will
  413. * respond to i2c accesses, so make sure we have
  414. * have the clock enabled before we attempt to
  415. * initialize the device.
  416. */
  417. for_each_pipe(dev_priv, pipe) {
  418. dpll[pipe] = I915_READ(DPLL(pipe));
  419. I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
  420. }
  421. dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
  422. /* restore the DVO 2x clock state to original */
  423. for_each_pipe(dev_priv, pipe) {
  424. I915_WRITE(DPLL(pipe), dpll[pipe]);
  425. }
  426. intel_gmbus_force_bit(i2c, false);
  427. if (!dvoinit)
  428. continue;
  429. intel_encoder->type = INTEL_OUTPUT_DVO;
  430. intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
  431. switch (dvo->type) {
  432. case INTEL_DVO_CHIP_TMDS:
  433. intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
  434. (1 << INTEL_OUTPUT_DVO);
  435. drm_connector_init(dev, connector,
  436. &intel_dvo_connector_funcs,
  437. DRM_MODE_CONNECTOR_DVII);
  438. encoder_type = DRM_MODE_ENCODER_TMDS;
  439. break;
  440. case INTEL_DVO_CHIP_LVDS:
  441. intel_encoder->cloneable = 0;
  442. drm_connector_init(dev, connector,
  443. &intel_dvo_connector_funcs,
  444. DRM_MODE_CONNECTOR_LVDS);
  445. encoder_type = DRM_MODE_ENCODER_LVDS;
  446. break;
  447. }
  448. drm_connector_helper_add(connector,
  449. &intel_dvo_connector_helper_funcs);
  450. connector->display_info.subpixel_order = SubPixelHorizontalRGB;
  451. connector->interlace_allowed = false;
  452. connector->doublescan_allowed = false;
  453. intel_connector_attach_encoder(intel_connector, intel_encoder);
  454. if (dvo->type == INTEL_DVO_CHIP_LVDS) {
  455. /* For our LVDS chipsets, we should hopefully be able
  456. * to dig the fixed panel mode out of the BIOS data.
  457. * However, it's in a different format from the BIOS
  458. * data on chipsets with integrated LVDS (stored in AIM
  459. * headers, likely), so for now, just get the current
  460. * mode being output through DVO.
  461. */
  462. intel_panel_init(&intel_connector->panel,
  463. intel_dvo_get_current_mode(connector),
  464. NULL);
  465. intel_dvo->panel_wants_dither = true;
  466. }
  467. drm_connector_register(connector);
  468. return;
  469. }
  470. drm_encoder_cleanup(&intel_encoder->base);
  471. kfree(intel_dvo);
  472. kfree(intel_connector);
  473. }