| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657 |
- /// NULL check before some freeing functions is not needed.
- ///
- /// Based on checkpatch warning
- /// "kfree(NULL) is safe this check is probably not required"
- /// and kfreeaddr.cocci by Julia Lawall.
- ///
- // Copyright: (C) 2014 Fabian Frederick. GPLv2.
- // Comments: -
- // Options: --no-includes --include-headers
- virtual patch
- virtual org
- virtual report
- virtual context
- @r2 depends on patch@
- expression E;
- @@
- - if (E != NULL)
- (
- kfree(E);
- |
- debugfs_remove(E);
- |
- debugfs_remove_recursive(E);
- |
- usb_free_urb(E);
- |
- kmem_cache_destroy(E);
- |
- mempool_destroy(E);
- |
- dma_pool_destroy(E);
- )
- @r depends on context || report || org @
- expression E;
- position p;
- @@
- * if (E != NULL)
- * \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|
- * usb_free_urb@p\|kmem_cache_destroy@p\|mempool_destroy@p\|
- * dma_pool_destroy@p\)(E);
- @script:python depends on org@
- p << r.p;
- @@
- cocci.print_main("NULL check before that freeing function is not needed", p)
- @script:python depends on report@
- p << r.p;
- @@
- msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
- coccilib.report.print_report(p[0], msg)
|
